From: Kees Monshouwer <mind04@monshouwer.org>
Date: Mon, 5 Jun 2017 20:04:38 +0000 (+0200)
Subject: auth: fix possible uninitalized variable in ldapbackend
X-Git-Tag: rec-4.1.0-alpha1~93^2~3
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6fdd7da4b05d81215c68419cfbb5b5b4e784650f;p=thirdparty%2Fpdns.git

auth: fix possible uninitalized variable in ldapbackend
---

diff --git a/modules/ldapbackend/ldapbackend.cc b/modules/ldapbackend/ldapbackend.cc
index 52a4bd454b..6c8d8adc84 100644
--- a/modules/ldapbackend/ldapbackend.cc
+++ b/modules/ldapbackend/ldapbackend.cc
@@ -541,7 +541,7 @@ bool LdapBackend::get( DNSResourceRecord &rr )
 void LdapBackend::getUpdatedMasters( vector<DomainInfo>* domains )
 {
   string filter;
-  int msgid;
+  int msgid=0;
   PowerLDAP::sentry_t result;
   const char* attronly[] = {
     "associatedDomain",
@@ -676,11 +676,11 @@ void LdapBackend::setNotified( uint32_t id, uint32_t serial )
 
 
 
-bool LdapBackend::getDomainInfo( const string& domain, DomainInfo& di )
+bool LdapBackend::getDomainInfo( const DNSName& domain, DomainInfo& di )
 {
   string filter;
   SOAData sd;
-  int msgid;
+  int msgid=0;
   PowerLDAP::sentry_t result;
   const char* attronly[] = {
     "sOARecord",
diff --git a/modules/ldapbackend/ldapbackend.hh b/modules/ldapbackend/ldapbackend.hh
index 265d93e800..8534a50313 100644
--- a/modules/ldapbackend/ldapbackend.hh
+++ b/modules/ldapbackend/ldapbackend.hh
@@ -143,7 +143,7 @@ class LdapBackend : public DNSBackend
     void lookup( const QType& qtype, const DNSName& qdomain, DNSPacket* p = 0, int zoneid = -1 ) override;
     bool get( DNSResourceRecord& rr ) override;
 
-    bool getDomainInfo( const string& domain, DomainInfo& di ) override;
+    bool getDomainInfo( const string& domain, DomainInfo& di ); // override; Broken overload
 
     // Master backend
     void getUpdatedMasters( vector<DomainInfo>* domains ) override;