From: James Jones <jejones3141@gmail.com>
Date: Fri, 23 Sep 2022 11:45:02 +0000 (-0500)
Subject: initialize buff to placate coverity (CIDs #1503942, #1504042) (#4738)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=6ffe7602767420d9a2e4149c034e3605d5c56abf;p=thirdparty%2Ffreeradius-server.git

initialize buff to placate coverity (CIDs #1503942, #1504042) (#4738)

Coverity doesn't realize that fr_sbuff_out_bstrncpy_allowed()
will put something in buff, if only a NUL terminator. Until
coverity sees annotations in macro definitions, the only way
I know of to avoid the false positive "uninit_use_in_call"
defects in SBUFF_PARSE_FLOAT_DEF()-generated functions is to
actually initialize buff.
---

diff --git a/src/lib/util/sbuff.c b/src/lib/util/sbuff.c
index c7f26940dbf..223db6206e5 100644
--- a/src/lib/util/sbuff.c
+++ b/src/lib/util/sbuff.c
@@ -1265,7 +1265,7 @@ SBUFF_PARSE_UINT_DEF(size_hex, size_t, SIZE_MAX, 22, 16)
 #define SBUFF_PARSE_FLOAT_DEF(_name, _type, _func, _max_char) \
 fr_slen_t fr_sbuff_out_##_name(fr_sbuff_parse_error_t *err, _type *out, fr_sbuff_t *in, bool no_trailing) \
 { \
-	char		buff[_max_char + 1]; \
+	char		buff[_max_char + 1] = ""; \
 	char		*end; \
 	fr_sbuff_t	our_in = FR_SBUFF(in); \
 	size_t		len; \
@@ -1279,7 +1279,6 @@ fr_slen_t fr_sbuff_out_##_name(fr_sbuff_parse_error_t *err, _type *out, fr_sbuff
 		return -1; \
 	} \
 	errno = 0; /* this is needed as parsing functions don't reset errno */ \
-	/* coverity[uninit_use_in_call] */ \
 	res = _func(buff, &end); \
 	if (errno == ERANGE) { \
 		if (res > 0) { \