From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 20 Sep 2023 00:25:33 +0000 (-0400)
Subject: don't write to buffer we're reading from
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=703239aa52ab22be4e6767f0aafe2dca24b1ba0b;p=thirdparty%2Ffreeradius-server.git

don't write to buffer we're reading from
---

diff --git a/src/lib/unlang/compile.c b/src/lib/unlang/compile.c
index b0490e7ae8e..cb677c8b68e 100644
--- a/src/lib/unlang/compile.c
+++ b/src/lib/unlang/compile.c
@@ -1010,8 +1010,8 @@ static unlang_t *compile_update_to_edit(unlang_t *parent, unlang_compile_t *unla
 	CONF_SECTION		*group;
 	unlang_group_t		*g;
 	char			list_buffer[32];
-	char			value_buffer[1024];
-	char			attr_buffer[2048];
+	char			value_buffer[256];
+	char			attr_buffer[256];
 	char const		*list;
 
 	g = unlang_generic_to_group(parent);
@@ -1173,9 +1173,9 @@ static unlang_t *compile_update_to_edit(unlang_t *parent, unlang_compile_t *unla
 
 		pair_op:
 			fr_assert(*attr != '&');
-			snprintf(attr_buffer, sizeof(attr_buffer), "%s.%s", list, attr);
+			snprintf(value_buffer, sizeof(value_buffer), "%s.%s", list, attr);
 
-			rcode = edit_pair_alloc(group, cp, attr_buffer, op, value, T_INVALID);
+			rcode = edit_pair_alloc(group, cp, value_buffer, op, value, T_INVALID);
 			break;
 
 		case T_OP_ADD_EQ: