From: Reed Loden <reed@reedloden.com>
Date: Fri, 24 Sep 2010 21:06:34 +0000 (-0700)
Subject: Bug 598698 - Remove unneeded selectrow_array() call in Bugzilla::Install::make_admin()
X-Git-Tag: bugzilla-4.1.1~264
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=707573450030f45f33ac464d393749d32c55ae73;p=thirdparty%2Fbugzilla.git

Bug 598698 - Remove unneeded selectrow_array() call in Bugzilla::Install::make_admin()
[r=mkanat a=mkanat]
---

diff --git a/Bugzilla/Install.pm b/Bugzilla/Install.pm
index 57b1904b5a..9d4426bbe8 100644
--- a/Bugzilla/Install.pm
+++ b/Bugzilla/Install.pm
@@ -345,14 +345,12 @@ sub make_admin {
     $user = ref($user) ? $user 
             : new Bugzilla::User(login_to_id($user, THROW_ERROR));
 
-    my $admin_group = new Bugzilla::Group({ name => 'admin' });
-
-    # Admins get explicit membership and bless capability for the admin group
-    $dbh->selectrow_array("SELECT id FROM groups WHERE name = 'admin'");
-
     my $group_insert = $dbh->prepare(
         'INSERT INTO user_group_map (user_id, group_id, isbless, grant_type)
               VALUES (?, ?, ?, ?)');
+
+    # Admins get explicit membership and bless capability for the admin group
+    my $admin_group = new Bugzilla::Group({ name => 'admin' });
     # These are run in an eval so that we can ignore the error of somebody
     # already being granted these things.
     eval {