From: Lidong Yan <502024330056@smail.nju.edu.cn>
Date: Wed, 4 Jun 2025 03:11:15 +0000 (+0000)
Subject: commit-graph: fix start_delayed_progress() leak
X-Git-Tag: v2.51.0-rc0~135^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7082da85cbd03404a21a3ba02158d7ab1989cfc2;p=thirdparty%2Fgit.git

commit-graph: fix start_delayed_progress() leak

In commit-graph.c:graph_write(), if read_one_commit() failed,
progress allocated in start_delayed_progress() will leak. Add
stop_progress() before goto cleanup.

Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
Acked-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index 8ca75262c5..bcd5ff6798 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -311,6 +311,7 @@ static int graph_write(int argc, const char **argv, const char *prefix,
 		while (strbuf_getline(&buf, stdin) != EOF) {
 			if (read_one_commit(&commits, progress, buf.buf)) {
 				result = 1;
+				stop_progress(&progress);
 				goto cleanup;
 			}
 		}