From: Daniel P. Berrange Date: Tue, 18 Nov 2014 16:02:11 +0000 (+0000) Subject: Fix flags passed to virDomainDefParseString by XenAPI driver X-Git-Tag: v1.2.12-rc1~61 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=70948db22ab46192b34f574b8bff5f31ae4778ca;p=thirdparty%2Flibvirt.git Fix flags passed to virDomainDefParseString by XenAPI driver The XenAPI driver was passing the flags for virDomainCreateXML straight into the virDomainDefParseString method, even though they expect totally different sets of flags. It should have been using VIR_DOMAIN_XML_INACTIVE --- diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 1ab433a6ae..2625794666 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -554,7 +554,7 @@ xenapiDomainCreateXML(virConnectPtr conn, virDomainDefPtr defPtr = virDomainDefParseString(xmlDesc, priv->caps, priv->xmlopt, 1 << VIR_DOMAIN_VIRT_XEN, - flags); + VIR_DOMAIN_XML_INACTIVE); createVMRecordFromXml(conn, defPtr, &record, &vm); virDomainDefFree(defPtr); if (record) { @@ -1728,7 +1728,7 @@ xenapiDomainDefineXMLFlags(virConnectPtr conn, const char *xml, unsigned int fla virDomainDefPtr defPtr = virDomainDefParseString(xml, priv->caps, priv->xmlopt, 1 << VIR_DOMAIN_VIRT_XEN, - 0); + VIR_DOMAIN_XML_INACTIVE); if (!defPtr) return NULL;