From: Ján Tomko <jtomko@redhat.com>
Date: Sun, 25 Nov 2012 01:59:33 +0000 (+0100)
Subject: storage: fix logical volume cloning
X-Git-Tag: CVE-2012-3411~77
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=70f0bbe8e046dae1b811378f735872d3e61f4609;p=thirdparty%2Flibvirt.git

storage: fix logical volume cloning

Commit 258e06c removed setting of the volume type to
VIR_STORAGE_VOL_BLOCK, which leads to failures in
storageVolumeCreateXMLFrom.

The type (and target.format) of the volume was set to zero. In
virStorageBackendGetBuildVolFromFunction, this gets interpreted as
VIR_STORAGE_FILE_NONE and the qemu-img tool is called with unknown
"none" format.

Bug: https://bugzilla.redhat.com/show_bug.cgi?id=879780
---

diff --git a/src/storage/storage_backend_logical.c b/src/storage/storage_backend_logical.c
index de43c3a429..fd5cbd12d8 100644
--- a/src/storage/storage_backend_logical.c
+++ b/src/storage/storage_backend_logical.c
@@ -708,6 +708,8 @@ virStorageBackendLogicalCreateVol(virConnectPtr conn,
         return -1;
     }
 
+    vol->type = VIR_STORAGE_VOL_BLOCK;
+
     if (vol->target.path != NULL) {
         /* A target path passed to CreateVol has no meaning */
         VIR_FREE(vol->target.path);