From: Max Kanat-Alexander <mkanat@bugzilla.org>
Date: Wed, 8 Sep 2010 01:38:57 +0000 (-0700)
Subject: Bug 516457: Bump the Email::MIME requirement to avoid a memory leak that
X-Git-Tag: bugzilla-4.0rc1~78
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=710539a655b26cfd3c72799f64bb8fd5b565655d;p=thirdparty%2Fbugzilla.git

Bug 516457: Bump the Email::MIME requirement to avoid a memory leak that
jobqueue.pl was hitting.
r=LpSolit, a=LpSolit
---

diff --git a/Bugzilla/Install/Requirements.pm b/Bugzilla/Install/Requirements.pm
index 12a9c20c57..f7809ec28c 100644
--- a/Bugzilla/Install/Requirements.pm
+++ b/Bugzilla/Install/Requirements.pm
@@ -116,18 +116,8 @@ sub REQUIRED_MODULES {
     {
         package => 'Email-MIME',
         module  => 'Email::MIME',
-        version => '1.861'
-    },
-    {
-        package => 'Email-MIME-Encodings',
-        module  => 'Email::MIME::Encodings',
-        # Fixes bug 486206
-        version => '1.313',
-    },
-    {
-        package => 'Email-MIME-Modifier',
-        module  => 'Email::MIME::Modifier',
-        version => '1.442'
+        # This fixes a memory leak in walk_parts that affected jobqueue.pl.
+        version => '1.904'
     },
     {
         package => 'URI',
diff --git a/Bugzilla/Mailer.pm b/Bugzilla/Mailer.pm
index c8a99b8730..d4a41b7638 100644
--- a/Bugzilla/Mailer.pm
+++ b/Bugzilla/Mailer.pm
@@ -48,8 +48,6 @@ use Encode qw(encode);
 use Encode::MIME::Header;
 use Email::Address;
 use Email::MIME;
-# Loading this gives us encoding_set.
-use Email::MIME::Modifier;
 use Email::Send;
 
 sub MessageToMTA {
diff --git a/docs/en/xml/installation.xml b/docs/en/xml/installation.xml
index b498acb810..f311149b6b 100644
--- a/docs/en/xml/installation.xml
+++ b/docs/en/xml/installation.xml
@@ -353,18 +353,6 @@
           </para>
         </listitem>
 
-        <listitem>
-          <para>
-            Email::MIME::Encodings (&min-email-mime-encodings-ver;)
-          </para>
-        </listitem>
-
-        <listitem>
-          <para>
-            Email::MIME::Modifier (&min-email-mime-modifier-ver;)
-          </para>
-        </listitem>
-
         <listitem>
           <para>
             Template (&min-template-ver;)