From: Karel Zak <kzak@redhat.com>
Date: Tue, 31 Jan 2012 12:39:49 +0000 (+0100)
Subject: libblkid: check for NULL in blkid_flush_cache() [coverity scan]
X-Git-Tag: v2.21-rc2~59
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=71107465768fdacfecf4c0be762fb345d4a0a51b;p=thirdparty%2Futil-linux.git

libblkid: check for NULL in blkid_flush_cache() [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/libblkid/src/save.c b/libblkid/src/save.c
index 9c1ab467ea..f0008ae53e 100644
--- a/libblkid/src/save.c
+++ b/libblkid/src/save.c
@@ -74,9 +74,11 @@ int blkid_flush_cache(blkid_cache cache)
 
 	filename = cache->bic_filename ? cache->bic_filename :
 					 blkid_get_cache_filename(NULL);
+	if (!filename)
+		return -BLKID_ERR_PARAM;
 
-	if (filename && strncmp(filename,
-		BLKID_RUNTIME_DIR "/", sizeof(BLKID_RUNTIME_DIR)) == 0) {
+	if (strncmp(filename,
+	    BLKID_RUNTIME_DIR "/", sizeof(BLKID_RUNTIME_DIR)) == 0) {
 
 		/* default destination, create the directory if necessary */
 		if (stat(BLKID_RUNTIME_DIR, &st) && errno == ENOENT) {