From: Pauli <ppzgs1@gmail.com>
Date: Tue, 16 Mar 2021 00:00:25 +0000 (+1000)
Subject: params: clean up TODO
X-Git-Tag: openssl-3.0.0-alpha14~264
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7128458b8ae264af012bf5f3c504ba73045f8567;p=thirdparty%2Fopenssl.git

params: clean up TODO

The TODO being reworked to just be a comment.

Fixes #14374

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/14565)
---

diff --git a/crypto/params_from_text.c b/crypto/params_from_text.c
index 3ff94c7475f..bf3ca616410 100644
--- a/crypto/params_from_text.c
+++ b/crypto/params_from_text.c
@@ -75,8 +75,8 @@ static int prepare_from_text(const OSSL_PARAM *paramdefs, const char *key,
         *buf_n = (buf_bits + 7) / 8;
 
         /*
-         * TODO(v3.0) is this the right way to do this?  This code expects
-         * a zero data size to simply mean "arbitrary size".
+         * A zero data size means "arbitrary size", so only do the
+         * range checking if a size is specified.
          */
         if (p->data_size > 0) {
             if (buf_bits > p->data_size * 8