From: Francisco R. Del Roio Date: Sun, 25 Feb 2024 13:36:01 +0000 (-0300) Subject: Added missing mypy tests for `AsyncConnection.run_sync`. X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=712b4382b16e4c07c09ac40a570c4bfb76c28161;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git Added missing mypy tests for `AsyncConnection.run_sync`. Thanks to @CaselIT --- diff --git a/test/typing/plain_files/ext/asyncio/engines.py b/test/typing/plain_files/ext/asyncio/engines.py index ae7880f584..1b13ff1e95 100644 --- a/test/typing/plain_files/ext/asyncio/engines.py +++ b/test/typing/plain_files/ext/asyncio/engines.py @@ -1,7 +1,14 @@ +from typing import Any + +from sqlalchemy import Connection from sqlalchemy import text from sqlalchemy.ext.asyncio import create_async_engine +def work_sync(conn: Connection, foo: int) -> Any: + pass + + async def asyncio() -> None: e = create_async_engine("sqlite://") @@ -53,3 +60,8 @@ async def asyncio() -> None: # EXPECTED_TYPE: CursorResult[Unpack[.*tuple[Any, ...]]] reveal_type(result) + + await conn.run_sync(work_sync, 1) + + # EXPECTED_MYPY: Missing positional argument "foo" in call to "run_sync" of "AsyncConnection" + await conn.run_sync(work_sync)