From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Wed, 15 Oct 2025 14:44:24 +0000 (+0300)
Subject: lib-settings: Fix memory leak with settings overrides
X-Git-Tag: 2.4.2~74
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=713538a2ca840923f40e11556739b2e457ff1611;p=thirdparty%2Fdovecot%2Fcore.git

lib-settings: Fix memory leak with settings overrides

The setting override lookups were allocating memory from wrong memory pool,
causing the process memory to keep growing.
---

diff --git a/src/lib-settings/settings.c b/src/lib-settings/settings.c
index 347a26c65f..6b22ce3a38 100644
--- a/src/lib-settings/settings.c
+++ b/src/lib-settings/settings.c
@@ -1862,7 +1862,7 @@ settings_override_set_blocks(struct settings_mmap *mmap,
 		return -1;
 	}
 
-	const char **block_names = p_new(mmap->pool, const char *, count + 1);
+	const char **block_names = p_new(set->pool, const char *, count + 1);
 	for (i = 0; i < count; i++) {
 		memcpy(&block_idx, blocks, sizeof(block_idx));
 		blocks = CONST_PTR_OFFSET(blocks, sizeof(block_idx));