From: Alvaro Herrera <alvherre@alvh.no-ip.org>
Date: Thu, 17 Mar 2011 15:28:46 +0000 (-0300)
Subject: Fix PL/Python memory leak involving array slices
X-Git-Tag: REL8_4_8~18
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7135bc5d6665fb9cf9452b660c0f7c3daa4a439b;p=thirdparty%2Fpostgresql.git

Fix PL/Python memory leak involving array slices

Report and patch from Daniel Popowich, bug #5842
(with some debugging help from Alex Hunsaker)
---

diff --git a/src/pl/plpython/plpython.c b/src/pl/plpython/plpython.c
index 79203f1c0e0..d126d875e58 100644
--- a/src/pl/plpython/plpython.c
+++ b/src/pl/plpython/plpython.c
@@ -2328,14 +2328,9 @@ PLy_result_ass_item(PyObject *arg, Py_ssize_t idx, PyObject *item)
 static PyObject *
 PLy_result_slice(PyObject *arg, Py_ssize_t lidx, Py_ssize_t hidx)
 {
-	PyObject   *rv;
 	PLyResultObject *ob = (PLyResultObject *) arg;
 
-	rv = PyList_GetSlice(ob->rows, lidx, hidx);
-	if (rv == NULL)
-		return NULL;
-	Py_INCREF(rv);
-	return rv;
+	return PyList_GetSlice(ob->rows, lidx, hidx);
 }
 
 static int