From: Mark Andrews Date: Wed, 5 Feb 2020 05:43:12 +0000 (+1100) Subject: 's' must be non NULL, remove test. X-Git-Tag: v9.16.0~29^2~4 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=714594d4689b77f174a7638861d9f3dc20f31f87;p=thirdparty%2Fbind9.git 's' must be non NULL, remove test. 122 cleanup: CID 1452696 (#1 of 1): Dereference before null check (REVERSE_INULL) check_after_deref: Null-checking s suggests that it may be null, but it has already been dereferenced on all paths leading to the check. 123 if (s != NULL) 124 isc_mem_free(mctx, s); --- diff --git a/bin/tests/system/dyndb/driver/driver.c b/bin/tests/system/dyndb/driver/driver.c index 887c9b5da92..27b8a8fc44e 100644 --- a/bin/tests/system/dyndb/driver/driver.c +++ b/bin/tests/system/dyndb/driver/driver.c @@ -120,8 +120,7 @@ dyndb_init(isc_mem_t *mctx, const char *name, const char *parameters, *instp = sample_inst; cleanup: - if (s != NULL) - isc_mem_free(mctx, s); + isc_mem_free(mctx, s); if (argv != NULL) isc_mem_put(mctx, argv, argc * sizeof(*argv));