From: Mark Michelson <mmichelson@digium.com>
Date: Wed, 13 May 2009 19:41:44 +0000 (+0000)
Subject: Remove an extraneous unlocking operation from ast_channel_free.
X-Git-Tag: 1.4.26~110
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7189d758051d3cf467dc1ca29337a766e92eb8b2;p=thirdparty%2Fasterisk.git

Remove an extraneous unlocking operation from ast_channel_free.

In the case that we could not remove the desired channel from the
list of channels, there was an extra call to unlock the channel list.
Since we unlock the list later on in the function anyway, this results
in the list being unlocked twice yet only being locked once.

(closes issue #15098)
Reported by: tim_ringenbach
Patches:
      remove_extra_unlock.diff uploaded by tim (license 540)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@194356 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/main/channel.c b/main/channel.c
index 6683d2b915..74929dcbbd 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -1225,7 +1225,6 @@ void ast_channel_free(struct ast_channel *chan)
 	
 	AST_LIST_LOCK(&channels);
 	if (!AST_LIST_REMOVE(&channels, chan, chan_list)) {
-		AST_LIST_UNLOCK(&channels);
 		ast_log(LOG_ERROR, "Unable to find channel in list to free. Assuming it has already been done.\n");
 	}
 	/* Lock and unlock the channel just to be sure nobody has it locked still