From: Matthew Jordan Date: Thu, 28 Feb 2013 16:49:46 +0000 (+0000) Subject: Let channels joining a MeetMe conference opt out of the denoiser X-Git-Tag: certified/1.8.15-cert2~10 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7191cb4be62eb527ae799964114a0b8b896ace47;p=thirdparty%2Fasterisk.git Let channels joining a MeetMe conference opt out of the denoiser For some channel drivers, specifically those that have a varying rate in the number of audio samples, the audio quality for a MeetMe conference can be exceedingly poor. This is due to a unilateral application of the DENOISE function in func_speex to channels joining the conference. The denoiser function in the speex library is initialized with the number of audio samples in each sample that will be provided to it. If the number of audio samples changes, the denoiser has to be thrown away and re-initialized. While this could be worked around by removing func_speex, that doesn't help if you actually use the denoiser with other channels on the system. This patches does the following: * Checks for the presence of func_speex as opposed to codec_speex when determining if the DENOISE function is present (which is where the function is actually implemented) * Adds an option to MeetMe 'n' that causes the denoiser to not be applied to a channel when it joins. This keeps the current behavior the default, but let's users disable the denoiser if it causes problems on their system. Review: https://reviewboard.asterisk.org/r/2358 (closes issue AST-1062) Reported by: Thomas Arimont ........ Merged revisions 382227 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/certified/branches/1.8.15@382228 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- diff --git a/UPGRADE.txt b/UPGRADE.txt index 507babd843..8e22cb736a 100644 --- a/UPGRADE.txt +++ b/UPGRADE.txt @@ -17,7 +17,15 @@ === UPGRADE-1.6.txt -- Upgrade info for 1.4 to 1.6 === =========================================================== -from 1.8.17 to 1.8.18: + +from 1.8.15-cert1 to 1.8.15-cert2 +* Added the 'n' option to MeetMe to prevent application of the DENOISE function + to a channel joining a conference. Some channel drivers that vary the number + of audio samples in a voice frame will experience significant quality problems + if a denoiser is attached to the channel; this option gives them the ability + to remove the denoiser without having to unload func_speex. + +from 1.8.11 to 1.8.15-cert1 * Queue strategy rrmemory now has a predictable order similar to strategy rrordered. Members will be called in the order that they are added to the queue. diff --git a/apps/app_meetme.c b/apps/app_meetme.c index 77db47bfc9..481a024c77 100644 --- a/apps/app_meetme.c +++ b/apps/app_meetme.c @@ -134,6 +134,14 @@ ASTERISK_FILE_VERSION(__FILE__, "$Revision$") channel's currently set music class, or default. +