From: Stéphane Graber <stgraber@ubuntu.com>
Date: Fri, 14 Feb 2014 21:07:41 +0000 (-0500)
Subject: coverity: Check fcntl return value
X-Git-Tag: lxc-1.0.0.rc2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=71b2940d87135239762951024557e51a58b8224b;p=thirdparty%2Flxc.git

coverity: Check fcntl return value

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Acked-by: Serge E. Hallyn <serge.hallyn@ubuntu.com>
---

diff --git a/src/lxc/attach.c b/src/lxc/attach.c
index 28cf91635..a59dae330 100644
--- a/src/lxc/attach.c
+++ b/src/lxc/attach.c
@@ -1026,8 +1026,11 @@ static int attach_child_main(void* data)
 		flags = fcntl(fd, F_GETFL);
 		if (flags < 0)
 			continue;
-		if (flags & FD_CLOEXEC)
-			fcntl(fd, F_SETFL, flags & ~FD_CLOEXEC);
+		if (flags & FD_CLOEXEC) {
+			if (fcntl(fd, F_SETFL, flags & ~FD_CLOEXEC) < 0) {
+				SYSERROR("Unable to clear CLOEXEC from fd");
+			}
+		}
 	}
 
 	/* we're done, so we can now do whatever the user intended us to do */