From: Sean Bright <sean.bright@gmail.com>
Date: Tue, 23 Mar 2021 20:15:45 +0000 (-0400)
Subject: app_queue.c: Remove dead 'updatecdr' code.
X-Git-Tag: 16.18.0-rc1~19
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=721589559045169b5a97da7788ae523dfda908a4;p=thirdparty%2Fasterisk.git

app_queue.c: Remove dead 'updatecdr' code.

Also removed the sample documentation, and some oddly-placed
documentation about the timeout argument to the Queue() application
itself. There is a large section on the timeout behavior below.

ASTERISK-26614 #close

Change-Id: I8f84e8304b50305b7c4cba2d9787a5d77c3a6217
---

diff --git a/apps/app_queue.c b/apps/app_queue.c
index 93bbdaa8b3..029e6bfb5b 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -1486,9 +1486,6 @@ static int realtime_rules = 0;
 /*! \brief Subscription to device state change messages */
 static struct stasis_subscription *device_state_sub;
 
-/*! \brief queues.conf [general] option */
-static int update_cdr = 0;
-
 /*! \brief queues.conf [general] option */
 static int negative_penalty_invalid = 0;
 
@@ -9218,10 +9215,6 @@ static void queue_set_global_params(struct ast_config *cfg)
 		if (!strcasecmp(general_val, "mixmonitor"))
 			montype_default = 1;
 	}
-	update_cdr = 0;
-	if ((general_val = ast_variable_retrieve(cfg, "general", "updatecdr"))) {
-		update_cdr = ast_true(general_val);
-	}
 	shared_lastcall = 0;
 	if ((general_val = ast_variable_retrieve(cfg, "general", "shared_lastcall"))) {
 		shared_lastcall = ast_true(general_val);
diff --git a/configs/samples/queues.conf.sample b/configs/samples/queues.conf.sample
index 79b656b75e..b81ffd81e1 100644
--- a/configs/samples/queues.conf.sample
+++ b/configs/samples/queues.conf.sample
@@ -41,19 +41,6 @@ persistentmembers = yes
 ;
 monitor-type = MixMonitor
 ;
-; UpdateCDR behavior.
-;    This option is implemented to mimic chan_agents behavior of populating
-;    CDR dstchannel field of a call with an agent name, which you can set
-;    at the login time with AddQueueMember membername parameter.
-;
-; updatecdr = no
-
-;
-; Note that a timeout to fail out of a queue may be passed as part of
-; an application call from extensions.conf:
-; Queue(queuename,[options],[optionalurl],[announceoverride],[timeout])
-; example: Queue(dave,t,,,45)
-
 ; shared_lastcall will make the lastcall and calls received be the same in
 ; members logged in more than one queue.  This is useful to make the queue
 ; respect the wrapuptime of another queue for a shared member.