From: Rico Tzschichholz <ricotz@ubuntu.com>
Date: Thu, 27 Aug 2020 08:02:19 +0000 (+0200)
Subject: libvaladoc/gtkdoc-importer: Correctly retrieve "url" from "ulink" elements
X-Git-Tag: 0.49.92~6
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=721aca1abd3a8c27995874bfccd10e59842969ce;p=thirdparty%2Fvala.git

libvaladoc/gtkdoc-importer: Correctly retrieve "url" from "ulink" elements

This caused criticals like:

  g_uri_parse_scheme: assertion 'uri != NULL' failed
---

diff --git a/libvaladoc/documentation/gtkdoccommentparser.vala b/libvaladoc/documentation/gtkdoccommentparser.vala
index 20535b764..c1b1d0ea8 100644
--- a/libvaladoc/documentation/gtkdoccommentparser.vala
+++ b/libvaladoc/documentation/gtkdoccommentparser.vala
@@ -358,7 +358,12 @@ public class Valadoc.Gtkdoc.Parser : Object, ResourceLocator {
 		}
 
 		StringBuilder builder = new StringBuilder ();
-		string url = current.attributes.get ("linkend");
+		string url;
+		if (is_internal) {
+			url = current.attributes.get ("linkend");
+		} else {
+			url = current.attributes.get ("url");
+		}
 		next ();
 
 		// TODO: check xml