From: Bob Halley <halley@dnspython.org>
Date: Fri, 2 Sep 2005 05:22:43 +0000 (+0000)
Subject: we specified dns.rdatatype.NONE instead of dns.rdataclass.NONE in some
X-Git-Tag: v1.3.4~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=726a5ded5a0b3cdc24fcf01738d34628d8d1f5fa;p=thirdparty%2Fdnspython.git

we specified dns.rdatatype.NONE instead of dns.rdataclass.NONE in some
update delete operations

Original author: Bob Halley <halley@dnspython.org>
Date: 2004-05-23 06:51:54
---

diff --git a/ChangeLog b/ChangeLog
index d59bf552..241509bb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2004-05-22  Bob Halley  <halley@dnspython.org>
 
+	* dns/update.py (Update.delete): We erroneously specified a
+	"deleting" value of dns.rdatatype.NONE instead of
+	dns.rdataclass.NONE when the thing being deleted was either an
+	Rdataset instance or an Rdata instance.
+
 	* dns/rdtypes/ANY/SSHFP.py: Added support for the proposed SSHFP
 	RR type.
 
diff --git a/dns/update.py b/dns/update.py
index 973610ee..e35f6b94 100644
--- a/dns/update.py
+++ b/dns/update.py
@@ -141,12 +141,12 @@ class Update(dns.message.Message):
         elif isinstance(args[0], dns.rdataset.Rdataset):
             for rds in args:
                 for rd in rds:
-                    self._add_rr(name, 0, rd, dns.rdatatype.NONE)
+                    self._add_rr(name, 0, rd, dns.rdataclass.NONE)
         else:
             args = list(args)
             if isinstance(args[0], dns.rdata.Rdata):
                 for rd in args:
-                    self._add_rr(name, 0, rd, dns.rdatatype.NONE)
+                    self._add_rr(name, 0, rd, dns.rdataclass.NONE)
             else:
                 rdtype = args.pop(0)
                 if isinstance(rdtype, str):