From: lpsolit%gmail.com <>
Date: Fri, 23 Dec 2005 10:08:46 +0000 (+0000)
Subject: Bug 316971: [PostgreSQL] ./collectstats.pl --regenerate fails - Patch by Frédéric... 
X-Git-Tag: bugzilla-2.20.1~49
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=72785e44b16335082b040783d5e212c781030e99;p=thirdparty%2Fbugzilla.git

Bug 316971: [PostgreSQL] ./collectstats.pl --regenerate fails - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=justdave
---

diff --git a/Bugzilla/DB.pm b/Bugzilla/DB.pm
index ec189b7eed..13d754e6bd 100644
--- a/Bugzilla/DB.pm
+++ b/Bugzilla/DB.pm
@@ -1118,6 +1118,13 @@ formatted SQL command have prefix C<sql_>. All other methods have prefix C<bz_>.
  Returns:     formatted SQL for limiting number of rows returned from query
               with optional offset (e.g. LIMIT 1, 1) (scalar)
 
+=item C<sql_from_days>
+
+ Description: Outputs SQL syntax for converting Julian days to date.
+              Abstract method, should be overriden by database specific code.
+ Params:      $days = days to convert to date
+ Returns:     formatted SQL for returning Julian days in dates. (scalar)
+
 =item C<sql_to_days>
 
  Description: Outputs SQL syntax for converting date to Julian days.
diff --git a/Bugzilla/DB/Mysql.pm b/Bugzilla/DB/Mysql.pm
index ecdf635178..c753e8883a 100644
--- a/Bugzilla/DB/Mysql.pm
+++ b/Bugzilla/DB/Mysql.pm
@@ -117,6 +117,12 @@ sub sql_istring {
     return $string;
 }
 
+sub sql_from_days {
+    my ($self, $days) = @_;
+
+    return "FROM_DAYS($days)";
+}
+
 sub sql_to_days {
     my ($self, $date) = @_;
 
diff --git a/Bugzilla/DB/Pg.pm b/Bugzilla/DB/Pg.pm
index 8fc522490a..e0a8e7ff5f 100644
--- a/Bugzilla/DB/Pg.pm
+++ b/Bugzilla/DB/Pg.pm
@@ -106,6 +106,12 @@ sub sql_limit {
     }
 }
 
+sub sql_from_days {
+    my ($self, $days) = @_;
+
+    return "TO_TIMESTAMP(${days}::int, 'J')::date";
+}
+
 sub sql_to_days {
     my ($self, $date) = @_;
 
diff --git a/collectstats.pl b/collectstats.pl
index e087c28d04..2d7d3d2584 100755
--- a/collectstats.pl
+++ b/collectstats.pl
@@ -286,7 +286,7 @@ sub regenerate_stats {
                         $dbh->sql_to_days('current_date') . " AS end, " .
                         $dbh->sql_to_days("'1970-01-01'") . 
             " FROM bugs $from_product WHERE " .
-            $dbh->sql_to_days('creation_ts') . " != 'NULL'" .
+            $dbh->sql_to_days('creation_ts') . " IS NOT NULL " .
             $and_product .
             " ORDER BY start " . $dbh->sql_limit(1));
     
@@ -316,8 +316,8 @@ FIN
             # Get a list of bugs that were created the previous day, and
             # add those bugs to the list of bugs for this product.
             SendSQL("SELECT bug_id FROM bugs $from_product " .
-                    "WHERE bugs.creation_ts < from_days(" . ($day - 1) . ") " . 
-                    "AND bugs.creation_ts >= from_days(" . ($day - 2) . ") " .
+                    " WHERE bugs.creation_ts < " . $dbh->sql_from_days($day - 1) .
+                    " AND bugs.creation_ts >= " . $dbh->sql_from_days($day - 2) .
                     $and_product .
                     " ORDER BY bug_id");
             
@@ -354,8 +354,8 @@ FIN
                         "    ON bugs_activity.fieldid = fielddefs.fieldid " .
                         " WHERE fielddefs.name = 'bug_status' " .
                         "   AND bugs_activity.bug_id = $bug " .
-                        "   AND bugs_activity.bug_when >= from_days($day) " .
-                      "ORDER BY bugs_activity.bug_when " .
+                        "   AND bugs_activity.bug_when >= " . $dbh->sql_from_days($day) .
+                     " ORDER BY bugs_activity.bug_when " .
                         $dbh->sql_limit(1));
                 
                 my $status;
@@ -377,8 +377,8 @@ FIN
                         "    ON bugs_activity.fieldid = fielddefs.fieldid " .
                         " WHERE fielddefs.name = 'resolution' " .
                         "   AND bugs_activity.bug_id = $bug " .
-                        "   AND bugs_activity.bug_when >= from_days($day) " .
-                      "ORDER BY bugs_activity.bug_when " . 
+                        "   AND bugs_activity.bug_when >= " . $dbh->sql_from_days($day) .
+                     " ORDER BY bugs_activity.bug_when " . 
                         $dbh->sql_limit(1));
                         
                 if (@row = FetchSQLData()) {