From: Jim Meyering <meyering@redhat.com>
Date: Thu, 18 Feb 2010 20:25:01 +0000 (+0100)
Subject: virBufferVSprintf: do not omit va_end(argptr) call
X-Git-Tag: v0.7.7~109
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=72919f3d354adf0b0b2be2956b24246da47fa280;p=thirdparty%2Flibvirt.git

virBufferVSprintf: do not omit va_end(argptr) call

* src/util/buf.c (virBufferVSprintf): Do not omit va_end(argptr).
Improved-by: Daniel Veillard.
---

diff --git a/src/util/buf.c b/src/util/buf.c
index cc0a0870e3..fc1217bf60 100644
--- a/src/util/buf.c
+++ b/src/util/buf.c
@@ -245,12 +245,15 @@ virBufferVSprintf(const virBufferPtr buf, const char *format, ...)
         va_end(locarg);
 
         grow_size = (count > 1000) ? count : 1000;
-        if (virBufferGrow(buf, grow_size) < 0)
+        if (virBufferGrow(buf, grow_size) < 0) {
+            va_end(argptr);
             return;
+        }
 
         size = buf->size - buf->use - 1;
         va_copy(locarg, argptr);
     }
+    va_end(argptr);
     va_end(locarg);
     buf->use += count;
     buf->content[buf->use] = '\0';