From: Damien Lespiau Date: Tue, 22 Sep 2015 16:11:46 +0000 (+0100) Subject: tests: Don't change settings.STATIC_URL in the XML-RPC tests X-Git-Tag: v1.1.0~144 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7297e509222854b88a5a220c2f092bfb863aad0f;p=thirdparty%2Fpatchwork.git tests: Don't change settings.STATIC_URL in the XML-RPC tests I tracked down a weird bug where the Selenium tests supposed to serve all static files (.css, .js. ...) weren't doing so when running the full test suite, but everything was working when running the tests in isolation. Turns out one of the other tests was changing settings.STATIC_URL mid-way without restoring the original value in tearDown() and thus impacting other tests. It seems that this change wasn't necessary, the XML-RPC server doesn't server any static file anyway. Signed-off-by: Damien Lespiau Acked-by: Stephen Finucane --- diff --git a/patchwork/tests/test_xmlrpc.py b/patchwork/tests/test_xmlrpc.py index d37c281d..2c1a18ad 100644 --- a/patchwork/tests/test_xmlrpc.py +++ b/patchwork/tests/test_xmlrpc.py @@ -31,7 +31,6 @@ class XMLRPCTest(LiveServerTestCase): fixtures = ['default_states'] def setUp(self): - settings.STATIC_URL = '/' self.url = (self.live_server_url + reverse('patchwork.views.xmlrpc.xmlrpc')) self.rpc = xmlrpclib.Server(self.url)