From: Gervase Markham <gerv@gerv.net>
Date: Tue, 8 Mar 2011 16:06:38 +0000 (+0000)
Subject: Bug 622513 - Email-related regexp checking should be case-insensitive. a=mkanat.
X-Git-Tag: bugzilla-4.1.1~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=729e221d58c1e0dafb027ddef399c9f5a210b1d0;p=thirdparty%2Fbugzilla.git

Bug 622513 - Email-related regexp checking should be case-insensitive. a=mkanat.
---

diff --git a/Bugzilla/WebService/User.pm b/Bugzilla/WebService/User.pm
index 9f118d4a6b..b9434059d3 100644
--- a/Bugzilla/WebService/User.pm
+++ b/Bugzilla/WebService/User.pm
@@ -95,7 +95,7 @@ sub offer_account_by_email {
     if (!$createexp) {
         ThrowUserError("account_creation_disabled");
     }
-    elsif ($email !~ /$createexp/) {
+    elsif ($email !~ /$createexp/i) {
         ThrowUserError("account_creation_restricted");
     }
 
diff --git a/createaccount.cgi b/createaccount.cgi
index c2941bc4c0..db0727adda 100755
--- a/createaccount.cgi
+++ b/createaccount.cgi
@@ -65,7 +65,7 @@ if (defined($login)) {
     $login = Bugzilla::User->check_login_name_for_creation($login);
     $vars->{'login'} = $login;
 
-    if ($login !~ /$createexp/) {
+    if ($login !~ /$createexp/i) {
         ThrowUserError("account_creation_restricted");
     }
 
diff --git a/template/en/default/admin/params/auth.html.tmpl b/template/en/default/admin/params/auth.html.tmpl
index 8e91e54c0e..2e11dffbce 100644
--- a/template/en/default/admin/params/auth.html.tmpl
+++ b/template/en/default/admin/params/auth.html.tmpl
@@ -120,7 +120,7 @@
                  "the <tt>emailregexp</tt> param to only allow local usernames, " _
                  "but you want the mail to be delivered to username@my.local.hostname.",
 
-  createemailregexp => "This defines the regexp to use for email addresses that are " _
+  createemailregexp => "This defines the (case-insensitive) regexp to use for email addresses that are " _
                        "permitted to self-register using a 'New Account' feature. The " _
                        "default (.*) permits any account matching the emailregexp " _
                        "to be created. If this parameter is left blank, no users " _