From: Karel Zak <kzak@redhat.com>
Date: Wed, 12 Dec 2012 11:27:05 +0000 (+0100)
Subject: libblkid: check mkdir(/run/blkid) return code [coverity scan]
X-Git-Tag: v2.23-rc1~430
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7317ba6d37f8e3600ddac6050f39c87b512c334c;p=thirdparty%2Futil-linux.git

libblkid: check mkdir(/run/blkid) return code [coverity scan]

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/libblkid/src/save.c b/libblkid/src/save.c
index 46925ab2a6..c94cc2a82d 100644
--- a/libblkid/src/save.c
+++ b/libblkid/src/save.c
@@ -81,11 +81,16 @@ int blkid_flush_cache(blkid_cache cache)
 	    BLKID_RUNTIME_DIR "/", sizeof(BLKID_RUNTIME_DIR)) == 0) {
 
 		/* default destination, create the directory if necessary */
-		if (stat(BLKID_RUNTIME_DIR, &st) && errno == ENOENT) {
-
-			mkdir(BLKID_RUNTIME_DIR, S_IWUSR|
-						 S_IRUSR|S_IRGRP|S_IROTH|
-						 S_IXUSR|S_IXGRP|S_IXOTH);
+		if (stat(BLKID_RUNTIME_DIR, &st)
+		    && errno == ENOENT
+		    && mkdir(BLKID_RUNTIME_DIR, S_IWUSR|
+						S_IRUSR|S_IRGRP|S_IROTH|
+						S_IXUSR|S_IXGRP|S_IXOTH) != 0
+		    && errno != EEXIST) {
+			DBG(DEBUG_SAVE,
+				printf("can't create %s directory for cache file\n",
+					BLKID_RUNTIME_DIR));
+			return 0;
 		}
 	}