From: Stefan Metzmacher <metze@samba.org>
Date: Thu, 23 Jan 2020 15:17:30 +0000 (+0100)
Subject: s3:auth_sam: make sure we never handle empty usernames
X-Git-Tag: samba-4.10.14~26
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=731ae2864d84e27fc1466852eb88976b1e11c67d;p=thirdparty%2Fsamba.git

s3:auth_sam: make sure we never handle empty usernames

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14247

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
(cherry picked from commit 01b8374e7942141e7f6cbdec7623c981a008e4c1)
---

diff --git a/source3/auth/auth_sam.c b/source3/auth/auth_sam.c
index 56f28ab94a6..e2c62f94d48 100644
--- a/source3/auth/auth_sam.c
+++ b/source3/auth/auth_sam.c
@@ -36,6 +36,12 @@ static NTSTATUS auth_sam_ignoredomain_auth(const struct auth_context *auth_conte
 		return NT_STATUS_UNSUCCESSFUL;
 	}
 
+	if (user_info->mapped.account_name == NULL ||
+	    user_info->mapped.account_name[0] == '\0')
+	{
+		return NT_STATUS_NOT_IMPLEMENTED;
+	}
+
 	DBG_DEBUG("Check auth for: [%s]\\[%s]\n",
 		  user_info->mapped.domain_name,
 		  user_info->mapped.account_name);
@@ -77,6 +83,12 @@ static NTSTATUS auth_samstrict_auth(const struct auth_context *auth_context,
 		return NT_STATUS_LOGON_FAILURE;
 	}
 
+	if (user_info->mapped.account_name == NULL ||
+	    user_info->mapped.account_name[0] == '\0')
+	{
+		return NT_STATUS_NOT_IMPLEMENTED;
+	}
+
 	DBG_DEBUG("Check auth for: [%s]\\[%s]\n",
 		  user_info->mapped.domain_name,
 		  user_info->mapped.account_name);
@@ -148,6 +160,12 @@ static NTSTATUS auth_sam_netlogon3_auth(const struct auth_context *auth_context,
 		return NT_STATUS_LOGON_FAILURE;
 	}
 
+	if (user_info->mapped.account_name == NULL ||
+	    user_info->mapped.account_name[0] == '\0')
+	{
+		return NT_STATUS_NOT_IMPLEMENTED;
+	}
+
 	DBG_DEBUG("Check auth for: [%s]\\[%s]\n",
 		  user_info->mapped.domain_name,
 		  user_info->mapped.account_name);