From: Michal Privoznik <mprivozn@redhat.com>
Date: Mon, 6 Feb 2017 08:09:12 +0000 (+0100)
Subject: qemuMonitorCPUModelInfoFree: Don't leak model_info->props
X-Git-Tag: CVE-2017-2635~130
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=732629dad3505066378090a4a79d8cdd00e98949;p=thirdparty%2Flibvirt.git

qemuMonitorCPUModelInfoFree: Don't leak model_info->props

==11846== 240 bytes in 1 blocks are definitely lost in loss record 81 of 107
==11846==    at 0x4C2BC75: calloc (vg_replace_malloc.c:624)
==11846==    by 0x18C74242: virAllocN (viralloc.c:191)
==11846==    by 0x4A05E8: qemuMonitorCPUModelInfoCopy (qemu_monitor.c:3677)
==11846==    by 0x446E3C: virQEMUCapsNewCopy (qemu_capabilities.c:2171)
==11846==    by 0x437335: testQemuCapsCopy (qemucapabilitiestest.c:108)
==11846==    by 0x437CD2: virTestRun (testutils.c:180)
==11846==    by 0x437AD8: mymain (qemucapabilitiestest.c:176)
==11846==    by 0x4397B6: virTestMain (testutils.c:992)
==11846==    by 0x437B44: main (qemucapabilitiestest.c:188)

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/qemu/qemu_monitor.c b/src/qemu/qemu_monitor.c
index 1308b6921e..b15207a693 100644
--- a/src/qemu/qemu_monitor.c
+++ b/src/qemu/qemu_monitor.c
@@ -3664,6 +3664,7 @@ qemuMonitorCPUModelInfoFree(qemuMonitorCPUModelInfoPtr model_info)
     for (i = 0; i < model_info->nprops; i++)
         VIR_FREE(model_info->props[i].name);
 
+    VIR_FREE(model_info->props);
     VIR_FREE(model_info->name);
     VIR_FREE(model_info);
 }