From: Jaco Kroon <jaco@uls.co.za>
Date: Fri, 2 Jun 2023 07:11:22 +0000 (+0200)
Subject: tcptls: when disabling a server port, we should set the accept_fd to -1.
X-Git-Tag: 21.0.0-pre1~52
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=73326fb4e07e5b242e634c6e7b3197de9f04e09d;p=thirdparty%2Fasterisk.git

tcptls: when disabling a server port, we should set the accept_fd to -1.

If we don't set this to -1 if the structure can be potentially re-used
later then it's possible that we'll issue a close() on an unrelated file
descriptor, breaking asterisk in other interesting ways.

I believe this to be an unlikely scenario, but it costs nothing to be
safe.

Signed-off-by: Jaco Kroon <jaco@uls.co.za>
---

diff --git a/main/tcptls.c b/main/tcptls.c
index dc25cb4047..e51e70ef0d 100644
--- a/main/tcptls.c
+++ b/main/tcptls.c
@@ -837,6 +837,7 @@ void ast_tcptls_server_start(struct ast_tcptls_session_args *desc)
 
 	if (desc->accept_fd != -1) {
 		close(desc->accept_fd);
+		desc->accept_fd = -1;
 	}
 
 	/* If there's no new server, stop here */