From: Jeremy Allison <jra@samba.org>
Date: Fri, 30 Jan 2009 01:27:47 +0000 (-0800)
Subject: Fix coverity CID#115. Resource leak in error path.
X-Git-Tag: samba-4.0.0alpha7~417^2~267
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=734647bd85560ed02691d79c0a613543043d8625;p=thirdparty%2Fsamba.git

Fix coverity CID#115. Resource leak in error path.
Jeremy.
---

diff --git a/source3/libnet/libnet_samsync_ldif.c b/source3/libnet/libnet_samsync_ldif.c
index 3068f8d3ebc..42863318935 100644
--- a/source3/libnet/libnet_samsync_ldif.c
+++ b/source3/libnet/libnet_samsync_ldif.c
@@ -776,7 +776,10 @@ static NTSTATUS fetch_alias_info_to_ldif(TALLOC_CTX *mem_ctx,
 	g_rid = r->rid;
 	groupmap->gidNumber = ldif_gid;
 	groupmap->sambaSID = talloc_asprintf(mem_ctx, "%s-%d", sid, g_rid);
-	NT_STATUS_HAVE_NO_MEMORY(groupmap->sambaSID);
+	if (groupmap->sambaSID == NULL) {
+		SAFE_FREE(group_attr);
+		return NT_STATUS_NO_MEMORY;
+	}
 
 	/* Write the data to the temporary add ldif file */
 	fprintf(add_fd, "# %s, %s, %s\n", aliasname, group_attr,