From: Eduardo San Martin Morote Date: Mon, 24 Apr 2023 07:54:36 +0000 (+0200) Subject: feat(warn): improve warning message X-Git-Tag: @pinia/nuxt@0.4.10~7 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=73518b3f94fb164d02e740cb3132767a0d2a397b;p=thirdparty%2Fvuejs%2Fpinia.git feat(warn): improve warning message --- diff --git a/package.json b/package.json index 383476c6..0e92f3c1 100644 --- a/package.json +++ b/package.json @@ -15,7 +15,7 @@ "lint": "prettier -c --parser typescript \"packages/*/{src,__tests__,e2e}/**/*.[jt]s?(x)\" \"packages/docs/**/*.[jt]s\"", "lint:fix": "pnpm run lint --write", "test": "pnpm run -r dev:prepare && pnpm run test:types && pnpm run test:vitest && pnpm run -r test && pnpm run build && pnpm run build:dts && pnpm test:dts", - "test:vitest": "vitest run --coverage", + "test:vitest": "vitest --coverage", "test:types": "tsc --build ./tsconfig.json", "test:dts": "pnpm run -r test:dts", "docs:api": "pnpm run --filter ./packages/docs -r docs:api" diff --git a/packages/pinia/__tests__/rootState.spec.ts b/packages/pinia/__tests__/rootState.spec.ts index be905258..0cb023ef 100644 --- a/packages/pinia/__tests__/rootState.spec.ts +++ b/packages/pinia/__tests__/rootState.spec.ts @@ -13,7 +13,7 @@ describe('Root State', () => { }) it('warns if creating a store without a pinia', () => { - expect(() => useA()).toThrowError(/with no active Pinia/) + expect(() => useA()).toThrowError(/there was no active Pinia/) }) it('works with no stores', () => { diff --git a/packages/pinia/src/store.ts b/packages/pinia/src/store.ts index 37ce278d..f5dd8a61 100644 --- a/packages/pinia/src/store.ts +++ b/packages/pinia/src/store.ts @@ -898,7 +898,7 @@ export function defineStore( if (__DEV__ && !activePinia) { throw new Error( - `[🍍]: getActivePinia was called with no active Pinia. Did you forget to install pinia?\n` + + `[🍍]: "getActivePinia()" was called but there was no active Pinia. Did you forget to install pinia?\n` + `\tconst pinia = createPinia()\n` + `\tapp.use(pinia)\n` + `This will fail in production.`