From: James Jones <jejones3141@gmail.com>
Date: Thu, 25 Aug 2022 20:45:51 +0000 (-0500)
Subject: Annotate false positive tainted_argument (CID #1419883) (#4696)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=739f694771eeacfbc2e11b42f9da8f437add0639;p=thirdparty%2Ffreeradius-server.git

Annotate false positive tainted_argument (CID #1419883) (#4696)

Coverity doesn't see that buffer[0] is checked twice, so
it can never be an invalid subscript for fr_packet_codes[].
---

diff --git a/src/listen/radius/proto_radius_tcp.c b/src/listen/radius/proto_radius_tcp.c
index 56be90e75f9..002a5260047 100644
--- a/src/listen/radius/proto_radius_tcp.c
+++ b/src/listen/radius/proto_radius_tcp.c
@@ -192,6 +192,7 @@ static ssize_t mod_read(fr_listen_t *li, UNUSED void **packet_ctx, fr_time_t *re
 	/*
 	 *	Print out what we received.
 	 */
+	/* coverity[tainted_data] */
 	DEBUG2("proto_radius_tcp - Received %s ID %d length %d %s",
 	       fr_packet_codes[buffer[0]], buffer[1],
 	       (int) packet_len, thread->name);