From: Joshua Rogers <MegaManSec@users.noreply.github.com>
Date: Wed, 10 Sep 2025 03:48:22 +0000 (+0000)
Subject: Do not leak file handle on _open_osfhandle() xaccept() failure (#2231)
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=73c731779986ab2971d3b15a9cc1a77c22bbacaf;p=thirdparty%2Fsquid.git

Do not leak file handle on _open_osfhandle() xaccept() failure (#2231)
---

diff --git a/compat/socket.cc b/compat/socket.cc
index 5fac7c2244..fd3c5c4f3f 100644
--- a/compat/socket.cc
+++ b/compat/socket.cc
@@ -34,8 +34,10 @@ xaccept(int socketFd, struct sockaddr *sa, socklen_t *saLength)
         return SOCKET_ERROR;
     }
     const auto rv = _open_osfhandle(result, 0);
-    if (rv == -1)
+    if (rv == -1) {
+        closesocket(result);
         errno = EBADF;
+    }
     if (saLength)
         *saLength = static_cast<socklen_t>(al);
     return rv;