From: Luca Boccassi <luca.boccassi@microsoft.com>
Date: Wed, 22 Dec 2021 18:31:15 +0000 (+0000)
Subject: analyze: do not connect to DBUS with --offline
X-Git-Tag: v250~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=741c4c8da91756ff7f614ac723fe1c6f05a01fb5;p=thirdparty%2Fsystemd.git

analyze: do not connect to DBUS with --offline

Co-authored-by: Lucas Werkmeister <mail@lucaswerkmeister.de>
---

diff --git a/src/analyze/analyze-security.c b/src/analyze/analyze-security.c
index d52518677cf..2691dc2c868 100644
--- a/src/analyze/analyze-security.c
+++ b/src/analyze/analyze-security.c
@@ -2770,7 +2770,7 @@ int analyze_security(sd_bus *bus,
         _cleanup_(table_unrefp) Table *overview_table = NULL;
         int ret = 0, r;
 
-        assert(bus);
+        assert(!!bus != offline);
 
         if (offline)
                 return offline_security_checks(units, policy, scope, check_man, run_generators, threshold, root, profile, pager_flags, json_format_flags);
diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c
index b3e00581ed3..a1908ff442a 100644
--- a/src/analyze/analyze.c
+++ b/src/analyze/analyze.c
@@ -2392,9 +2392,11 @@ static int do_security(int argc, char *argv[], void *userdata) {
         int r;
         unsigned line, column;
 
-        r = acquire_bus(&bus, NULL);
-        if (r < 0)
-                return bus_log_connect_error(r, arg_transport);
+        if (!arg_offline) {
+                r = acquire_bus(&bus, NULL);
+                if (r < 0)
+                        return bus_log_connect_error(r, arg_transport);
+        }
 
         pager_open(arg_pager_flags);