From: Wen Congyang <wency@cn.fujitsu.com>
Date: Wed, 30 May 2012 09:20:44 +0000 (+0800)
Subject: command: check for fork error before closing fd
X-Git-Tag: v0.9.13-rc1~163
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=746ff701e8727439cac8ca72531d82e5cb7fa129;p=thirdparty%2Flibvirt.git

command: check for fork error before closing fd

We should not set *outfd or *errfd if virExecWithHook() failed
because the caller may close these fds.

Bug present since v0.4.5 (commit 60ed1d2a).
---

diff --git a/src/util/command.c b/src/util/command.c
index 1a225082ce..ba43078450 100644
--- a/src/util/command.c
+++ b/src/util/command.c
@@ -492,6 +492,10 @@ virExecWithHook(const char *const*argv,
     }
 
     if (pid) { /* parent */
+        if (forkRet < 0) {
+            goto cleanup;
+        }
+
         VIR_FORCE_CLOSE(null);
         if (outfd && *outfd == -1) {
             VIR_FORCE_CLOSE(pipeout[1]);
@@ -502,10 +506,6 @@ virExecWithHook(const char *const*argv,
             *errfd = pipeerr[0];
         }
 
-        if (forkRet < 0) {
-            goto cleanup;
-        }
-
         *retpid = pid;
 
         if (binary != argv[0])