From: Martin Schwenke <martin@meltin.net>
Date: Tue, 15 Feb 2022 21:50:24 +0000 (+1100)
Subject: source4/torture: Avoid unused variable
X-Git-Tag: tevent-0.12.0~691
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7471afaa1ffcf8291c7d13cf41eec451dde37a42;p=thirdparty%2Fsamba.git

source4/torture: Avoid unused variable

clang complains:

../../source4/torture/basic/delete.c:2342:7: error: variable 'correct' set but not used [-Werror,-Wunused-but-set-variable]
        bool correct = true;
             ^

That is, the variable is initialised and updated but the value is
never used.  Similar functions return this variable, so try that.

Signed-off-by: Martin Schwenke <martin@meltin.net>
Reviewed-by: Volker Lendecke <vl@samba.org>
---

diff --git a/source4/torture/basic/delete.c b/source4/torture/basic/delete.c
index d14d5a55746..201ebfda60c 100644
--- a/source4/torture/basic/delete.c
+++ b/source4/torture/basic/delete.c
@@ -2387,7 +2387,7 @@ static bool deltest23(struct torture_context *tctx,
 	torture_assert_ntstatus_equal(tctx, smbcli_nt_error(cli1->tree),
 	    NT_STATUS_DELETE_PENDING, "smbcli_open failed");
 
-	return true;
+	return correct;
 }
 
 /* Test 24 ... */