From: Jouni Malinen <jouni.malinen@atheros.com>
Date: Wed, 13 Apr 2011 22:27:38 +0000 (+0300)
Subject: Use type cast to get rid of implicit sign extension
X-Git-Tag: hostap-1-bp~415
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74727a7b32b7f24aef0372bebf3198ce5c2f123d;p=thirdparty%2Fhostap.git

Use type cast to get rid of implicit sign extension

The size_t value here can be 64-bit and result in implicit sign
extension. In this particular case, that gets masked out by
host_to_be32(), so there is no practical difference, but it is better
to get rid of the 64-bit variable explicitly.
---

diff --git a/src/eap_peer/eap_ttls.c b/src/eap_peer/eap_ttls.c
index 25737803b..e8f0f38f0 100644
--- a/src/eap_peer/eap_ttls.c
+++ b/src/eap_peer/eap_ttls.c
@@ -202,7 +202,7 @@ static u8 * eap_ttls_avp_hdr(u8 *avphdr, u32 avp_code, u32 vendor_id,
 	}
 
 	avp->avp_code = host_to_be32(avp_code);
-	avp->avp_length = host_to_be32((flags << 24) | (hdrlen + len));
+	avp->avp_length = host_to_be32((flags << 24) | (u32) (hdrlen + len));
 
 	return avphdr + hdrlen;
 }