From: Andreas Henriksson <andreas@fatal.se>
Date: Tue, 25 Aug 2015 16:27:40 +0000 (+0200)
Subject: lib/strutil: fix parse_switch resource leak [coverity scan]
X-Git-Tag: v2.27~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74819b5f6421cb06029e8355ea8b06190be9b7c1;p=thirdparty%2Futil-linux.git

lib/strutil: fix parse_switch resource leak [coverity scan]

Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---

diff --git a/lib/strutils.c b/lib/strutils.c
index b033f7592b..30dc090b4f 100644
--- a/lib/strutils.c
+++ b/lib/strutils.c
@@ -198,10 +198,13 @@ int parse_switch(const char *arg, const char *errmesg, ...)
 		if (!b)
 			break;
 
-		if (strcmp(arg, a) == 0)
+		if (strcmp(arg, a) == 0) {
+			va_end(ap);
 			return 1;
-		else if (strcmp(arg, b) == 0)
+		} else if (strcmp(arg, b) == 0) {
+			va_end(ap);
 			return 0;
+		}
 	} while (1);
 	va_end(ap);