From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Thu, 20 Jul 2023 01:26:27 +0000 (+1200)
Subject: libcli/security: Cast isupper() argument to ‘unsigned char’
X-Git-Tag: tevent-0.16.0~1237
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=748cbac2fa7067bb11e6ad693d92ba7c00f47c61;p=thirdparty%2Fsamba.git

libcli/security: Cast isupper() argument to ‘unsigned char’

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/libcli/security/sddl.c b/libcli/security/sddl.c
index 022d20917b2..ec0dac765a1 100644
--- a/libcli/security/sddl.c
+++ b/libcli/security/sddl.c
@@ -555,7 +555,7 @@ static struct security_acl *sddl_decode_acl(struct security_descriptor *sd,
 	if (acl == NULL) return NULL;
 	acl->revision = SECURITY_ACL_REVISION_ADS;
 
-	if (isupper(sddl[0]) && sddl[1] == ':') {
+	if (isupper((unsigned char)sddl[0]) && sddl[1] == ':') {
 		/* its an empty ACL */
 		return acl;
 	}