From: Philippe Antoine <contact@catenacyber.fr>
Date: Mon, 15 May 2023 07:43:14 +0000 (+0200)
Subject: output/dnp3: restrict function scope to one file
X-Git-Tag: suricata-8.0.0-beta1~1489
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74aa80022c97e7afd3341d778b0ccfaf3052de7e;p=thirdparty%2Fsuricata.git

output/dnp3: restrict function scope to one file
---

diff --git a/src/output-json-dnp3.c b/src/output-json-dnp3.c
index 4336e04e07..1387d62136 100644
--- a/src/output-json-dnp3.c
+++ b/src/output-json-dnp3.c
@@ -140,7 +140,7 @@ static void JsonDNP3LogObjects(JsonBuilder *js, DNP3ObjectList *objects)
     }
 }
 
-void JsonDNP3LogRequest(JsonBuilder *js, DNP3Transaction *dnp3tx)
+static void JsonDNP3LogRequest(JsonBuilder *js, DNP3Transaction *dnp3tx)
 {
     JB_SET_STRING(js, "type", "request");
 
@@ -171,7 +171,7 @@ void JsonDNP3LogRequest(JsonBuilder *js, DNP3Transaction *dnp3tx)
     jb_close(js);
 }
 
-void JsonDNP3LogResponse(JsonBuilder *js, DNP3Transaction *dnp3tx)
+static void JsonDNP3LogResponse(JsonBuilder *js, DNP3Transaction *dnp3tx)
 {
     if (dnp3tx->ah.function_code == DNP3_APP_FC_UNSOLICITED_RESP) {
         JB_SET_STRING(js, "type", "unsolicited_response");
diff --git a/src/output-json-dnp3.h b/src/output-json-dnp3.h
index 064421a0b1..5abc2774b4 100644
--- a/src/output-json-dnp3.h
+++ b/src/output-json-dnp3.h
@@ -20,9 +20,6 @@
 
 #include "app-layer-dnp3.h"
 
-void JsonDNP3LogRequest(JsonBuilder *js, DNP3Transaction *);
-void JsonDNP3LogResponse(JsonBuilder *js, DNP3Transaction *);
-
 void JsonDNP3LogRegister(void);
 bool AlertJsonDnp3(void *vtx, JsonBuilder *js);