From: Daniel P. Berrangé <berrange@redhat.com>
Date: Thu, 8 Dec 2022 09:45:20 +0000 (+0000)
Subject: meson: remove obsolete check for ETH_FLAG_LRO
X-Git-Tag: v9.0.0-rc1~182
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74bbf364422083272d6d2b95f966dd242200fed3;p=thirdparty%2Flibvirt.git

meson: remove obsolete check for ETH_FLAG_LRO

The ETH_FLAG_LRO constant was introduced to Linux in

  commit 3ae7c0b2e3747b50c3a6c63ebb67469e0a6b3203
  Author: Jeff Garzik <jeff@garzik.org>
  Date:   Wed Aug 15 16:00:51 2007 -0700

    [ETHTOOL]: Add ETHTOOL_[GS]FLAGS sub-ioctls

This is old enough that all our supported platforms can be assumed
to have this feature.

Reviewed-by: Ján Tomko <jtomko@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/meson.build b/meson.build
index 4703b2c670..3194c2f9af 100644
--- a/meson.build
+++ b/meson.build
@@ -653,7 +653,6 @@ symbols = [
   [ 'linux/ethtool.h', 'ETH_FLAG_TXVLAN' ],
   [ 'linux/ethtool.h', 'ETH_FLAG_NTUPLE' ],
   [ 'linux/ethtool.h', 'ETH_FLAG_RXHASH' ],
-  [ 'linux/ethtool.h', 'ETH_FLAG_LRO' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GFEATURES' ],
   [ 'linux/ethtool.h', 'ETHTOOL_SCOALESCE' ],
   [ 'linux/ethtool.h', 'ETHTOOL_GCOALESCE' ],
diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c
index fe58975067..926609b898 100644
--- a/src/util/virnetdev.c
+++ b/src/util/virnetdev.c
@@ -3089,9 +3089,7 @@ virNetDevGetEthtoolFeatures(const char *ifname,
 
     /* ethtool masks */
     struct virNetDevEthtoolFeatureCmd flags[] = {
-# if WITH_DECL_ETH_FLAG_LRO
         {ETH_FLAG_LRO, VIR_NET_DEV_FEAT_LRO},
-# endif
 # if WITH_DECL_ETH_FLAG_TXVLAN
         {ETH_FLAG_RXVLAN, VIR_NET_DEV_FEAT_RXVLAN},
         {ETH_FLAG_TXVLAN, VIR_NET_DEV_FEAT_TXVLAN},