From: Michael Tremer Date: Wed, 30 Jun 2021 17:50:05 +0000 (+0000) Subject: packagelist: Drop unused conditional push function X-Git-Tag: 0.9.28~1141 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74cac540e13892e12f3b1314429d4e0083aa869e;p=pakfire.git packagelist: Drop unused conditional push function Signed-off-by: Michael Tremer --- diff --git a/src/libpakfire/include/pakfire/packagelist.h b/src/libpakfire/include/pakfire/packagelist.h index 64a01d146..68c002911 100644 --- a/src/libpakfire/include/pakfire/packagelist.h +++ b/src/libpakfire/include/pakfire/packagelist.h @@ -35,7 +35,6 @@ void pakfire_packagelist_sort(struct pakfire_packagelist* list); struct pakfire_package* pakfire_packagelist_get(struct pakfire_packagelist* list, unsigned int index); void pakfire_packagelist_push(struct pakfire_packagelist* list, struct pakfire_package* pkg); -void pakfire_packagelist_push_if_not_exists(struct pakfire_packagelist* list, struct pakfire_package* pkg); #ifdef PAKFIRE_PRIVATE diff --git a/src/libpakfire/libpakfire.sym b/src/libpakfire/libpakfire.sym index 27856333b..b665c776f 100644 --- a/src/libpakfire/libpakfire.sym +++ b/src/libpakfire/libpakfire.sym @@ -205,7 +205,6 @@ global: pakfire_packagelist_create; pakfire_packagelist_get; pakfire_packagelist_push; - pakfire_packagelist_push_if_not_exists; pakfire_packagelist_ref; pakfire_packagelist_sort; pakfire_packagelist_unref; diff --git a/src/libpakfire/packagelist.c b/src/libpakfire/packagelist.c index 01e28a18c..e6bf25dd8 100644 --- a/src/libpakfire/packagelist.c +++ b/src/libpakfire/packagelist.c @@ -115,23 +115,7 @@ PAKFIRE_EXPORT struct pakfire_package* pakfire_packagelist_get(struct pakfire_pa return NULL; } -static int pakfire_packagelist_has(struct pakfire_packagelist* list, struct pakfire_package* pkg) { - for (unsigned int i = 0; i < list->count; i++) { - if (pakfire_package_eq(pkg, list->elements[i])) - return 1; - } - - return 0; -} - PAKFIRE_EXPORT void pakfire_packagelist_push(struct pakfire_packagelist* list, struct pakfire_package* pkg) { list->elements = solv_extend(list->elements, list->count, 1, sizeof(pkg), BLOCK_SIZE); list->elements[list->count++] = pakfire_package_ref(pkg); } - -PAKFIRE_EXPORT void pakfire_packagelist_push_if_not_exists(struct pakfire_packagelist* list, struct pakfire_package* pkg) { - if (pakfire_packagelist_has(list, pkg)) - return; - - pakfire_packagelist_push(list, pkg); -}