From: Oliver Kurth <okurth@vmware.com>
Date: Mon, 30 Sep 2019 23:24:27 +0000 (-0700)
Subject: Add a Coverity annotation to lib/vmGuestLib/vmGuestLib.c
X-Git-Tag: stable-11.1.0~223
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74e08b1f9abf5d06e9e8fb9af40306270c5b1f43;p=thirdparty%2Fopen-vm-tools.git

Add a Coverity annotation to lib/vmGuestLib/vmGuestLib.c

A previous change adding Coverity annotations to vmGuestLib.c
omitted one.  Adding for completeness although it does not actually
affect Coverity results.
---

diff --git a/open-vm-tools/libguestlib/vmGuestLib.c b/open-vm-tools/libguestlib/vmGuestLib.c
index e7f779531..5cf0c811a 100644
--- a/open-vm-tools/libguestlib/vmGuestLib.c
+++ b/open-vm-tools/libguestlib/vmGuestLib.c
@@ -1837,6 +1837,12 @@ VMGuestLibIoctl(const GuestLibIoctlParam *param,
    }
    if (!DynXdr_AppendRaw(&xdrs, request, strlen(request)) ||
        !xdr_GuestLibIoctlParam(&xdrs, (GuestLibIoctlParam *)param)) {
+
+      /*
+       * DynXdr_Destroy only tries to free storage returned by a call to
+       * DynXdr_Create(NULL).
+       */
+      /* coverity[address_free] */
       DynXdr_Destroy(&xdrs, TRUE);
       return FALSE;
    }