From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Wed, 9 Aug 2023 04:51:33 +0000 (+1200)
Subject: lib:mscat: Remove unnecessary casts
X-Git-Tag: tevent-0.16.0~641
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74e1bb05712c82d683ab600d93a7a42b871dee4a;p=thirdparty%2Fsamba.git

lib:mscat: Remove unnecessary casts

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
---

diff --git a/lib/mscat/mscat_ctl.c b/lib/mscat/mscat_ctl.c
index 1fed8854c4b..292aa9aa6d5 100644
--- a/lib/mscat/mscat_ctl.c
+++ b/lib/mscat/mscat_ctl.c
@@ -315,7 +315,7 @@ static int ctl_get_member_checksum_string(struct mscat_ctl *ctl,
 				   CH_UNIX,
 				   chksum_ucs2.data,
 				   chksum_ucs2.length,
-				   (void **)&checksum,
+				   &checksum,
 				   &converted_size);
 	if (!ok) {
 		rc = -1;
@@ -450,7 +450,7 @@ static int ctl_parse_name_value(struct mscat_ctl *ctl,
 				   CH_UNIX,
 				   name_blob.data,
 				   name_blob.length,
-				   (void **)pname,
+				   pname,
 				   &converted_size);
 	if (!ok) {
 		rc = ASN1_MEM_ERROR;
@@ -464,7 +464,7 @@ static int ctl_parse_name_value(struct mscat_ctl *ctl,
 				   CH_UNIX,
 				   value_blob.data,
 				   value_blob.length,
-				   (void **)pvalue,
+				   pvalue,
 				   &converted_size);
 	if (!ok) {
 		rc = ASN1_MEM_ERROR;
@@ -543,7 +543,7 @@ static int ctl_parse_member_info(struct mscat_ctl *ctl,
 				   CH_UNIX,
 				   name_blob.data,
 				   name_blob.length,
-				   (void **)pname,
+				   pname,
 				   &converted_size);
 	if (!ok) {
 		rc = ASN1_MEM_ERROR;
@@ -679,7 +679,7 @@ static int ctl_spc_pe_image_data(struct mscat_ctl *ctl,
 						   CH_UNIX,
 						   file_blob.data,
 						   file_blob.length,
-						   (void **)&file,
+						   &file,
 						   &converted_size);
 			if (!ok) {
 				rc = -1;