From: Ondřej Surý <ondrej@isc.org>
Date: Wed, 25 Jun 2025 06:25:41 +0000 (+0200)
Subject: Fix implicit headers when using isc/overflow.h header
X-Git-Tag: v9.21.10~9^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74e5f5c6cf69f494b6a9765fc90d38465953e76a;p=thirdparty%2Fbind9.git

Fix implicit headers when using isc/overflow.h header

In jemalloc_shim.h, we relied on including <isc/overflow.h> implicitly
instead of explicitly and same was happening inside isc/overflow.h - the
stdbool.h (for bool type) was being included implicitly instead of
explicitly.
---

diff --git a/lib/isc/include/isc/overflow.h b/lib/isc/include/isc/overflow.h
index c272cfa8793..62727513ad2 100644
--- a/lib/isc/include/isc/overflow.h
+++ b/lib/isc/include/isc/overflow.h
@@ -13,6 +13,8 @@
 
 #pragma once
 
+#include <stdbool.h>
+
 #include <isc/util.h>
 
 /*
diff --git a/lib/isc/jemalloc_shim.h b/lib/isc/jemalloc_shim.h
index 1f6ef0fc44d..a29d7c0ecdc 100644
--- a/lib/isc/jemalloc_shim.h
+++ b/lib/isc/jemalloc_shim.h
@@ -16,8 +16,10 @@
 #if !defined(HAVE_JEMALLOC)
 
 #include <stddef.h>
+#include <stdlib.h>
 #include <string.h>
 
+#include <isc/overflow.h>
 #include <isc/util.h>
 
 const char *malloc_conf = NULL;
@@ -26,8 +28,6 @@ const char *malloc_conf = NULL;
 #define MALLOCX_TCACHE_NONE (0)
 #define MALLOCX_ARENA(a)    (0)
 
-#include <stdlib.h>
-
 typedef union {
 	size_t size;
 	max_align_t __alignment;