From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 17 Aug 2017 16:30:37 +0000 (-0700)
Subject: nohup: simplify by using fcntl
X-Git-Tag: v8.28~28
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=74fcbe5225608ab6914023465ddc4226d83f9282;p=thirdparty%2Fcoreutils.git

nohup: simplify by using fcntl

* src/nohup.c: Do not include cloexec.h.
(main): Use fcntl rather than dup + set_cloexec_flag.
---

diff --git a/src/nohup.c b/src/nohup.c
index 1641dc784d..53ec17f96c 100644
--- a/src/nohup.c
+++ b/src/nohup.c
@@ -24,7 +24,6 @@
 
 #include "system.h"
 
-#include "cloexec.h"
 #include "error.h"
 #include "filenamecat.h"
 #include "fd-reopen.h"
@@ -182,12 +181,8 @@ main (int argc, char **argv)
          if execve fails.  It's no big deal if this dup fails.  It might
          not change anything, and at worst, it'll lead to suppression of
          the post-failed-execve diagnostic.  */
-      saved_stderr_fd = dup (STDERR_FILENO);
-
-      if (0 <= saved_stderr_fd
-          && set_cloexec_flag (saved_stderr_fd, true) != 0)
-        error (exit_internal_failure, errno,
-               _("failed to set the copy of stderr to close on exec"));
+      saved_stderr_fd = fcntl (STDERR_FILENO, F_DUPFD_CLOEXEC,
+                               STDERR_FILENO + 1);
 
       if (!redirecting_stdout)
         error (0, 0,