From: Alan T. DeKok <aland@freeradius.org>
Date: Thu, 14 Apr 2022 15:04:39 +0000 (-0400)
Subject: *out may be NULL.  CID #1503963
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=751d29e6e426687340638791dc1c3cd2c3e27c2c;p=thirdparty%2Ffreeradius-server.git

*out may be NULL.  CID #1503963
---

diff --git a/src/lib/util/dict_unknown.c b/src/lib/util/dict_unknown.c
index 3b3c29d0dbe..74f36e00cc0 100644
--- a/src/lib/util/dict_unknown.c
+++ b/src/lib/util/dict_unknown.c
@@ -450,8 +450,12 @@ ssize_t fr_dict_unknown_afrom_oid_substr(TALLOC_CTX *ctx,
 	case FR_DICT_ATTR_OK:
 		if (is_raw) {
 			*out = fr_dict_unknown_attr_afrom_da(ctx, our_parent);
-			(*out)->flags.is_raw = 1;
-			if (err) *err = *out ? FR_DICT_ATTR_OK : FR_DICT_ATTR_PARSE_ERROR;
+			if (!*out) {
+				if (err) *err = FR_DICT_ATTR_PARSE_ERROR;
+			} else {
+				(*out)->flags.is_raw = 1;
+				if (err) *err = FR_DICT_ATTR_OK;
+			}
 		} else {
 			*out = fr_dict_attr_unconst(our_parent);	/* Which is the resolved attribute in this case */
 			if (err) *err = FR_DICT_ATTR_OK;