From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 13 Jun 2023 23:41:07 +0000 (-0700)
Subject: [3.12] gh-105436: Ignore unrelated errors when checking empty env (GH-105742) (#105756)
X-Git-Tag: v3.12.0b3~29
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=75239d5ec1505b8f9f20d3c2d366c1a3ebd269aa;p=thirdparty%2FPython%2Fcpython.git

[3.12] gh-105436: Ignore unrelated errors when checking empty env (GH-105742) (#105756)

gh-105436: Ignore unrelated errors when checking empty env (GH-105742)
(cherry picked from commit 4cefe3cf10f498c0927ae4fdba4880d5a64826e4)

Co-authored-by: Steve Dower <steve.dower@python.org>
---

diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
index 3d4fffbb8e79..817eab0c8a7e 100644
--- a/Lib/test/test_subprocess.py
+++ b/Lib/test/test_subprocess.py
@@ -1695,9 +1695,10 @@ class RunFuncTestCase(BaseTestCase):
     @unittest.skipUnless(mswindows, "Maybe test trigger a leak on Ubuntu")
     def test_run_with_an_empty_env(self):
         # gh-105436: fix subprocess.run(..., env={}) broken on Windows
-        args = [sys.executable, "-c", 'import sys; sys.exit(57)']
-        res = subprocess.run(args, env={})
-        self.assertEqual(res.returncode, 57)
+        args = [sys.executable, "-c", 'pass']
+        # Ignore subprocess errors - we only care that the API doesn't
+        # raise an OSError
+        subprocess.run(args, env={})
 
     def test_capture_output(self):
         cp = self.run_python(("import sys;"