From: Noel Power <noel.power@suse.com>
Date: Thu, 15 Aug 2019 15:25:27 +0000 (+0100)
Subject: s3/passdb: clang: Fix 'Value stored during its initialization is never read'
X-Git-Tag: talloc-2.3.1~562
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=752f5b63d0c4e0a7cdab74128ea54ade461d18d0;p=thirdparty%2Fsamba.git

s3/passdb: clang: Fix 'Value stored during its initialization is never read'

Fixes:

source3/passdb/pdb_util.c:41:11: warning: Value stored to 'status' during its initialization is never read <--[clang]
        NTSTATUS status = NT_STATUS_OK;
                 ^~~~~~   ~~~~~~~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/passdb/pdb_util.c b/source3/passdb/pdb_util.c
index 780c03fdc8d..b732acacd85 100644
--- a/source3/passdb/pdb_util.c
+++ b/source3/passdb/pdb_util.c
@@ -38,7 +38,7 @@
 static NTSTATUS add_sid_to_builtin(const struct dom_sid *builtin_sid,
 				   const struct dom_sid *dom_sid)
 {
-	NTSTATUS status = NT_STATUS_OK;
+	NTSTATUS status;
 
 	if (!dom_sid || !builtin_sid) {
 		return NT_STATUS_INVALID_PARAMETER;