From: Paul Floyd <pjfloyd@wanadoo.fr>
Date: Thu, 15 Jan 2026 07:44:52 +0000 (+0100)
Subject: Bug 514613 - Unclosed leak_summary/still_reachable tag in xml output
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=758b0f55e878fd7bd9dcd1ff3e74f10a7a00a771;p=thirdparty%2Fvalgrind.git

Bug 514613 - Unclosed leak_summary/still_reachable tag in xml output
---

diff --git a/NEWS b/NEWS
index d5188f7c6..3f6667fed 100644
--- a/NEWS
+++ b/NEWS
@@ -67,7 +67,8 @@ are not entered into bugzilla tend to get forgotten about or ignored.
 513522  m_libcassert.c: 'ordered comparison of pointer with integer zero'
         compiler warning
 513475  Add SSE4.1 PMULLD instruction for x86 32 bit
-514094  readlink("/proc/self/exe") overwrites buffer beyond its return value 
+514094  readlink("/proc/self/exe") overwrites buffer beyond its return value
+514613  Unclosed leak_summary/still_reachable tag in xml output
 
 To see details of a given bug, visit
   https://bugs.kde.org/show_bug.cgi?id=XXXXXX
diff --git a/memcheck/mc_leakcheck.c b/memcheck/mc_leakcheck.c
index 586bff448..4df0b180d 100644
--- a/memcheck/mc_leakcheck.c
+++ b/memcheck/mc_leakcheck.c
@@ -1768,7 +1768,8 @@ static void print_results(ThreadId tid, LeakCheckParams* lcp)
       umsg_or_xml(VG_(clo_xml) ?
                   "  <still_reachable>\n"
                   "    <bytes>%'lu%s</bytes>\n"
-                  "    <blocks>%'lu%s</blocks>\n" :
+                  "    <blocks>%'lu%s</blocks>\n"
+                  "  </still_reachable>\n" :
                   "   still reachable: %'lu%s bytes in %'lu%s blocks\n",
                 MC_(bytes_reachable), 
                 DBY (MC_(bytes_reachable), old_bytes_reachable),