From: Jeff Lucovsky <jlucovsky@oisf.net>
Date: Mon, 20 Jan 2025 13:46:39 +0000 (-0500)
Subject: detect/csum: rm interaction btw stream setting/csum
X-Git-Tag: suricata-8.0.0-beta1~499
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=758da982f087dce249012304de7d3077adf9bade;p=thirdparty%2Fsuricata.git

detect/csum: rm interaction btw stream setting/csum

Issue: 7467

Stream checksum validation no longer has a side effect of setting
PKT_IGNORE_CHECKSUM and thus, no longer affects csum keyword checks.
---

diff --git a/src/stream-tcp.c b/src/stream-tcp.c
index 7352f2bdc7..f0e5f3bcf3 100644
--- a/src/stream-tcp.c
+++ b/src/stream-tcp.c
@@ -5958,11 +5958,7 @@ TmEcode StreamTcp (ThreadVars *tv, Packet *p, void *data, PacketQueueNoLock *pq)
                 StatsIncr(tv, stt->counter_tcp_invalid_checksum);
                 return TM_ECODE_OK;
             }
-        } else {
-            p->flags |= PKT_IGNORE_CHECKSUM;
         }
-    } else {
-        p->flags |= PKT_IGNORE_CHECKSUM; //TODO check that this is set at creation
     }
     AppLayerProfilingReset(stt->ra_ctx->app_tctx);